Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add a file (CSV) tap for testing (WIP!) #2668

Merged
merged 10 commits into from
Sep 17, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Sep 13, 2024

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (0659295) to head (23cbfcc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2668      +/-   ##
==========================================
+ Coverage   89.87%   90.20%   +0.32%     
==========================================
  Files          58       58              
  Lines        4891     4891              
  Branches      963      963              
==========================================
+ Hits         4396     4412      +16     
+ Misses        344      331      -13     
+ Partials      151      148       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon added this to the v0.41.0 milestone Sep 16, 2024
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/test/test-sample-file-tap branch from c419168 to 411c461 Compare September 17, 2024 00:34
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/test/test-sample-file-tap branch from 411c461 to ad4e7f3 Compare September 17, 2024 00:34
Copy link

codspeed-hq bot commented Sep 17, 2024

CodSpeed Performance Report

Merging #2668 will not alter performance

Comparing edgarrmondragon/test/test-sample-file-tap (23cbfcc) with main (83b3d49)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 17, 2024 19:04
@edgarrmondragon edgarrmondragon requested a review from a team as a code owner September 17, 2024 19:04
@edgarrmondragon edgarrmondragon merged commit 3d3ac7b into main Sep 17, 2024
36 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/test/test-sample-file-tap branch September 17, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant