Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix coverage measurement on Windows #2161

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jan 19, 2024

Copy link

codspeed-hq bot commented Jan 19, 2024

CodSpeed Performance Report

Merging #2161 will not alter performance

Comparing edgarrmondragon/ci/windows-coverage (b4c40d4) with main (815f9c0)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/ci/windows-coverage branch from ce4c367 to 3e3fd44 Compare January 19, 2024 16:03
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/ci/windows-coverage branch from 3e3fd44 to b4c40d4 Compare January 19, 2024 16:04
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (815f9c0) 88.03% compared to head (b4c40d4) 88.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2161      +/-   ##
==========================================
+ Coverage   88.03%   88.35%   +0.31%     
==========================================
  Files          60       54       -6     
  Lines        5008     4696     -312     
  Branches     1014      957      -57     
==========================================
- Hits         4409     4149     -260     
+ Misses        423      389      -34     
+ Partials      176      158      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 19, 2024 16:15
@edgarrmondragon edgarrmondragon requested a review from a team as a code owner January 19, 2024 16:15
@edgarrmondragon edgarrmondragon merged commit ac28095 into main Jan 19, 2024
33 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/ci/windows-coverage branch January 19, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant