feat: Support validating configuration for any tap with a dynamic cat…

…alog
meltano · Sep 2, 2022 · be8e0eb · be8e0eb
1 parent b5af06a
commit be8e0eb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/samples/sample_tap_sqlite/__init__.py b/samples/sample_tap_sqlite/__init__.py
@@ -60,6 +60,7 @@ class SQLiteTap(SQLTap):
             DB_PATH_CONFIG,
             th.StringType,
             description="The path to your SQLite database file(s).",
+            required=True,
         )
     ).to_dict()
 

diff --git a/samples/sample_target_sqlite/__init__.py b/samples/sample_target_sqlite/__init__.py
@@ -66,6 +66,7 @@ class SQLiteTarget(SQLTarget):
             DB_PATH_CONFIG,
             th.StringType,
             description="The path to your SQLite database file(s).",
+            required=True,
         )
     ).to_dict()
 

diff --git a/singer_sdk/tap_base.py b/singer_sdk/tap_base.py
@@ -43,6 +43,10 @@ class Tap(PluginBase, metaclass=abc.ABCMeta):
     plugins.
     """
 
+    dynamic_catalog: bool = False
+    """Whether the tap's catalog is dynamic. Set to True if the catalog is
+    generated dynamically (e.g. by querying a database's system tables)."""
+
     # Constructor
 
     def __init__(
@@ -435,7 +439,7 @@ def cb_discover(
         tap = cls(
             config=config_files,
             parse_env_config=parse_env_config,
-            validate_config=False,
+            validate_config=cls.dynamic_catalog,
         )
         tap.run_discovery()
         ctx.exit()
@@ -524,6 +528,7 @@ class SQLTap(Tap):
 
     # Stream class used to initialize new SQL streams from their catalog declarations.
     default_stream_class: Type[SQLStream]
+    dynamic_catalog: bool = True
 
     def __init__(
         self,