Skip to content

Commit

Permalink
Document get_schema_names behavior
Browse files Browse the repository at this point in the history
  • Loading branch information
visch authored Aug 16, 2023
1 parent 1f62ae4 commit 7e7088c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions singer_sdk/connectors/sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,7 @@ def discover_catalog_entries(self) -> list[dict]:
result: list[dict] = []
engine = self._engine
inspected = sqlalchemy.inspect(engine)
# get_schema_names returns all databases in the DB, not just schemas
for schema_name in self.get_schema_names(engine, inspected):
# Iterate through each table and view
for table_name, is_view in self.get_object_names(
Expand Down

0 comments on commit 7e7088c

Please sign in to comment.