Add sql extra

meltano · Jan 19, 2024 · 45413f5 · 45413f5
1 parent 2fd5164
commit 45413f5
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 2 deletions.
diff --git a/cookiecutter/tap-template/{{cookiecutter.tap_id}}/pyproject.toml b/cookiecutter/tap-template/{{cookiecutter.tap_id}}/pyproject.toml
@@ -31,15 +31,23 @@ packages = [
 [tool.poetry.dependencies]
 python = ">=3.8"
 importlib-resources = { version = "==6.1.*", python = "<3.9" }
+{%- if cookiecutter.stream_type == 'SQL' %}
+singer-sdk = { version="~=0.34.1", extras = ["sql"] }
+{%- else %}
 singer-sdk = { version="~=0.34.1" }
+{%- endif %}
 fs-s3fs = { version = "~=1.1.1", optional = true }
 {%- if cookiecutter.stream_type in ["REST", "GraphQL"] %}
 requests = "~=2.31.0"
 {%- endif %}
 
 [tool.poetry.group.dev.dependencies]
 pytest = ">=7.4.0"
+{%- if cookiecutter.stream_type == 'SQL' %}
+singer-sdk = { version="~=0.34.1", extras = ["sql", "testing"] }
+{%- else %}
 singer-sdk = { version="~=0.34.1", extras = ["testing"] }
+{%- endif %}
 
 [tool.poetry.extras]
 s3 = ["fs-s3fs"]

diff --git a/cookiecutter/target-template/{{cookiecutter.target_id}}/pyproject.toml b/cookiecutter/target-template/{{cookiecutter.target_id}}/pyproject.toml
@@ -30,15 +30,23 @@ packages = [
 
 [tool.poetry.dependencies]
 python = ">=3.8"
+{%- if cookiecutter.serialization_method == 'SQL' %}
+singer-sdk = { version="~=0.34.1", extras = ["sql"] }
+{%- else %}
 singer-sdk = { version="~=0.34.1" }
+{%- endif %}
 fs-s3fs = { version = "~=1.1.1", optional = true }
 {%- if cookiecutter.serialization_method != "SQL" %}
 requests = "~=2.31.0"
 {%- endif %}
 
 [tool.poetry.dev-dependencies]
 pytest = ">=7.4.0"
+{%- if cookiecutter.serialization_method == 'SQL' %}
+singer-sdk = { version="~=0.34.1", extras = ["sql", "testing"] }
+{%- else %}
 singer-sdk = { version="~=0.34.1", extras = ["testing"] }
+{%- endif %}
 
 [tool.poetry.extras]
 s3 = ["fs-s3fs"]

diff --git a/noxfile.py b/noxfile.py
@@ -79,7 +79,7 @@ def mypy(session: Session) -> None:
 @session(python=python_versions)
 def tests(session: Session) -> None:
     """Execute pytest tests and compute coverage."""
-    session.install(".[s3,parquet]")
+    session.install(".[parquet,s3,sql]")
     session.install(*test_dependencies)
 
     sqlalchemy_version = os.environ.get("SQLALCHEMY_VERSION")

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -113,6 +113,7 @@ docs = [
     "sphinx-reredirects",
 ]
 s3 = ["fs-s3fs"]
+sql = ["sqlalchemy"]
 testing = [
     "pytest",
     "pytest-durations"