Skip to content

Commit

Permalink
refactor: Remove non-functional record-flattening capability (#2666)
Browse files Browse the repository at this point in the history
* Document missing `schema-flattening` base capability

* Remove unused `record-flattening` capability
  • Loading branch information
ReubenFrankel authored Sep 12, 2024
1 parent 998083a commit 170f5bc
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ plugins:
capabilities:
- about
- stream-maps
- record-flattening
- schema-flattening

# TODO: Declare settings and their types here:
settings:
Expand Down
2 changes: 1 addition & 1 deletion docs/capabilities.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ The following capabilities are supported by default.
.. autoattribute:: PluginCapabilities.ABOUT
.. autoattribute:: PluginCapabilities.BATCH
.. autoattribute:: PluginCapabilities.STREAM_MAPS
.. autoattribute:: PluginCapabilities.FLATTENING

========================
Custom base capabilities
Expand Down Expand Up @@ -60,5 +61,4 @@ The following capabilities have to be implemented in the target.
.. autoattribute:: TargetCapabilities.SOFT_DELETE
.. autoattribute:: TargetCapabilities.HARD_DELETE
.. autoattribute:: TargetCapabilities.DATATYPE_FAILSAFE
.. autoattribute:: TargetCapabilities.RECORD_FLATTENING
.. autoattribute:: TargetCapabilities.TARGET_SCHEMA
3 changes: 0 additions & 3 deletions singer_sdk/helpers/capabilities.py
Original file line number Diff line number Diff line change
Expand Up @@ -365,9 +365,6 @@ class TargetCapabilities(CapabilitiesEnum):
#: Fail safe for unknown JSON Schema types.
DATATYPE_FAILSAFE = "datatype-failsafe"

#: Allow denesting complex properties.
RECORD_FLATTENING = "record-flattening"

#: Allow setting the target schema.
TARGET_SCHEMA = "target-schema"

Expand Down

0 comments on commit 170f5bc

Please sign in to comment.