Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadowroot to shadowrootmode #18855

Merged
merged 3 commits into from
Feb 20, 2023
Merged

shadowroot to shadowrootmode #18855

merged 3 commits into from
Feb 20, 2023

Conversation

rachelandrew
Copy link
Collaborator

In Chrome 111 the shadowroot attribute for <template> has been renamed to shadowrootmode to match the updated spec.

I've updated BCD here, making shadowroot an alternative name, and I'll add updating the docs to our worklist.

https://chromestatus.com/feature/5161240576393216

@github-actions github-actions bot added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Feb 9, 2023
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did any renaming also happen for the IDL reflected property or is there none?

@mfreed7
Copy link
Contributor

mfreed7 commented Feb 15, 2023

Did any renaming also happen for the IDL reflected property or is there none?

Yes, there is now an IDL reflected property shadowRootMode which reflects the string content attribute. Previously, there was a shadowRoot IDL which always returned null, and that is now gone.

@mfreed7
Copy link
Contributor

mfreed7 commented Feb 15, 2023

Did any renaming also happen for the IDL reflected property or is there none?

Yes, there is now an IDL reflected property shadowRootMode which reflects the string content attribute. Previously, there was a shadowRoot IDL which always returned null, and that is now gone.

One more note about that - neither of these was "useful" for anything other than feature detection of declarative Shadow DOM. Setting the shadowRootMode property doesn't do anything because DSD is a parser-only feature.

@Elchi3
Copy link
Member

Elchi3 commented Feb 16, 2023

Thanks @mfreed7!
I don't see HTMLTemplateElement.shadowRootMode in BCD (I guess it is installed under HTMLTemplateElement?).
Is the new IDL anywhere? Looks like PRs to the specs aren't merged yet, so it is hard to find stuff for us, I'm afraid.

This PR looks fine as is but I guess it would be great to follow up on the other changes that got made related to this.

@mfreed7
Copy link
Contributor

mfreed7 commented Feb 17, 2023

Thanks @mfreed7! I don't see HTMLTemplateElement.shadowRootMode in BCD (I guess it is installed under HTMLTemplateElement?). Is the new IDL anywhere? Looks like PRs to the specs aren't merged yet, so it is hard to find stuff for us, I'm afraid.

This PR looks fine as is but I guess it would be great to follow up on the other changes that got made related to this.

Right - the declarative shadow DOM spec PR (whatwg/html#5465) hasn't yet landed. It's held up on one last issue, whatwg/html#8759.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointers! Going to merge this one. We will likely follow-up with the new additions soon then.

@Elchi3 Elchi3 merged commit de4b622 into mdn:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants