[Draft] API for Databases #298
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into database-api
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 46 49 +3
Lines 2818 2875 +57
Branches 345 350 +5
=========================================
+ Hits 2818 2875 +57
|
|
It must be merged after #297 |
mdabrowski1990
commented
Nov 22, 2024
| raise ValueError("Database has no encoding defined for provided SID value.") | ||
| return self.services[sid].encode(**data_records_values) | ||
|
|
||
| def decode(self, message: Union[UdsMessage, UdsMessageRecord]) -> List[DecodedDataRecord]: |
There was a problem hiding this comment.
Consider switching output to:
Dict[str, DecodedDataRecord] to simplify output (order does not matter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Process
I know the process and did my best to follow it