Update guild.py (automod things) #76
Conversation
Fixed issues with create_automod_rule and added fetch_automod_rule Signed-off-by: LukeZ <117578407+LukeZNotFound@users.noreply.github.com>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: This pull request introduces enhancements to the discord/guild.py module by fixing issues with the existing create_automod_rule function and adding a new function, fetch_automod_rule, to fetch a single Auto Moderation rule by its ID. The changes aim to improve the functionality and flexibility of handling Auto Moderation rules within a guild.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Ensure that the newly introduced fetch_automod_rule function is thoroughly tested, especially in scenarios where the rule ID does not exist or the user lacks the necessary permissions.
- Consider adding more detailed documentation or examples on how the fetch_automod_rule and create_automod_rule functions can be used in conjunction, to provide users with a clearer understanding of their capabilities.
- Review the changes made to the create_automod_rule function, particularly the handling of event_type and trigger_type parameters, to ensure they align with the intended design and do not introduce any regressions.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
| async def fetch_automod_rule(self, rule_id: int) -> AutoModRule: | ||
| """|coro| | ||
|
|
||
| Fetches a Auto Moderation rule for this guild by their ID |
There was a problem hiding this comment.
nitpick (llm): There's a minor grammatical error in the documentation. It should be 'Fetches an Auto Moderation rule for this guild by its ID' instead of 'Fetches a Auto Moderation rule for this guild by their ID'.
Fixed issues with create_automod_rule and added fetch_automod_rule (to fetch a single rule)