Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix electron:dev task on windows #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jan-zajic
Copy link
Contributor

Fix electron:dev npm task to run also on Windows OS.

@mb21
Copy link
Owner

mb21 commented Jul 16, 2021

Thanks, I quickly tried this on macOS and got:

yarn run v1.22.10
$ concurrently " set BROWSER=none && yarn start" "wait-on http://localhost:3000 && yarn run electron:tsc -w" "wait-on http://localhost:3000 && yarn run electron:tsc -p electron && set ELECTRON_IS_DEV=1 && electron .
/bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
/bin/sh: -c: line 1: syntax error: unexpected end of file
error Command failed with exit code 2.

@jan-zajic
Copy link
Contributor Author

Thank you, sorry for little mistake.. '"' lost somehow during merging/rebasing.. Can you please try it again?

@mb21
Copy link
Owner

mb21 commented Jul 16, 2021

While it runs now, the env variables aren't set. I don't think there's a syntax that works on both unix and windows... so probably best to add a new command electron:dev:windows or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants