Skip to content
This repository has been archived by the owner on Dec 8, 2023. It is now read-only.

Commit

Permalink
chore: update legacy URLs and usernames
Browse files Browse the repository at this point in the history
  • Loading branch information
maxpatiiuk committed May 8, 2023
1 parent 5168ce3 commit bf09a97
Show file tree
Hide file tree
Showing 7 changed files with 20 additions and 20 deletions.
2 changes: 1 addition & 1 deletion .github/dependabot.yml.disabled
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ updates:
schedule:
interval: "monthly"
assignees:
- "maxxxxxdlp"
- "maxpatiiuk"
- package-ecosystem: "github-actions"
directory: "/"
schedule:
Expand Down
6 changes: 3 additions & 3 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
#
# WARNING:
# Parts of this file are auto-generated
# For more info, see https://github.com/maxxxxxdlp/pre-commit-tools
# For more info, see https://github.com/maxpatiiuk/pre-commit-tools

default_language_version:
python: python3
Expand Down Expand Up @@ -58,7 +58,7 @@ repos:
- id: fix-encoding-pragma
- id: forbid-new-submodules

- repo: https://github.com/maxxxxxdlp/pre-commit
- repo: https://github.com/maxpatiiuk/pre-commit
rev: v1.0.6
hooks:
- id: tsc
Expand Down Expand Up @@ -173,7 +173,7 @@ repos:
args:
- --git-recurse

- repo: https://github.com/maxxxxxdlp/mirrors-jscpd
- repo: https://github.com/maxpatiiuk/mirrors-jscpd
rev: v3.3.26
hooks:
- id: jscpd
Expand Down
4 changes: 2 additions & 2 deletions LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
MIT License

Copyright (c) 2021 Maksym Patiiuk
Copyright (c) 2021 Max Patiiuk

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand All @@ -18,4 +18,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
SOFTWARE.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ An HTML5 Canvas-based browser walking & building game.

[Video Demo](https://www.youtube.com/watch?v=3guzbg383WA)

[Live Demo](https://maxxxxxdlp.github.io/eecs-448-pixelland/eecs-448-project-3/)
[Live Demo](https://maxpatiiuk.github.io/eecs-448-pixelland/eecs-448-project-3/)

[Description of the development process](https://max.patii.uk/projects/pixelland)

Expand Down
16 changes: 8 additions & 8 deletions documentation/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ works cited.
Clone this repository

```zsh
git clone https://github.com/maxxxxxdlp/eecs-448-pixelland
git clone https://github.com/maxpatiiuk/eecs-448-pixelland
```

To start a development server, navigate to the inner `eecs-448-project-3`
Expand Down Expand Up @@ -101,7 +101,7 @@ npm i # install development dependencies
Clone this repository

```zsh
git clone https://github.com/maxxxxxdlp/eecs-448-pixelland
git clone https://github.com/maxpatiiuk/eecs-448-pixelland
```

Configure a reverse proxy (e.x Nginx) that would serve eecs-448-project-3 folder
Expand Down Expand Up @@ -147,11 +147,11 @@ issue.

**Fixed issues:**

https://github.com/maxxxxxdlp/eecs-448-pixelland/issues?q=is%3Aissue+is%3Aclosed
https://github.com/maxpatiiuk/eecs-448-pixelland/issues?q=is%3Aissue+is%3Aclosed

**Backlog of issues:**

https://github.com/maxxxxxdlp/eecs-448-pixelland/issues
https://github.com/maxpatiiuk/eecs-448-pixelland/issues

**Code Review Document**:

Expand Down Expand Up @@ -397,7 +397,7 @@ descriptions for each class in order to maintain readability.

We've gone with a collection of features approach for our requirements, and they
can be found
[here](https://github.com/maxxxxxdlp/eecs-448-project-3/issues?q=is%3Aissue).
[here](https://github.com/maxpatiiuk/eecs-448-project-3/issues?q=is%3Aissue).

### Time Estimate

Expand All @@ -419,14 +419,14 @@ results had been satisfactory.
### Code References

- The boilerplate for a starter project was copied from
[here](https://github.com/maxxxxxdlp/max.patii.uk). Then, it was modified to
[here](https://github.com/maxpatiiuk/max.patii.uk). Then, it was modified to
remove dependency on Next.js, React and Tailwind.CSS
- Game board is rendered using table elements for the sake of accessibility, but
it is styled as a grid, for the sake of convenience.
[User-agent table styles reset](https://github.com/maxxxxxdlp/eecs-448-battleship/blob/main/eecs-448-battleship/components/Board/styles.css#L12)
[User-agent table styles reset](https://github.com/maxpatiiuk/eecs-448-battleship/blob/main/eecs-448-battleship/components/Board/styles.css#L12)
was copied from [here](https://stackoverflow.com/a/27851231/8584605) (with
modifications)
- [Basic OOP implementation of MVC](https://github.com/maxxxxxdlp/eecs-448-battleship/blob/1c3ab08b1ac0621307e7af35c2ad064e9491836a/eecs-448-battleship/lib/js/view.js#L11)
- [Basic OOP implementation of MVC](https://github.com/maxpatiiuk/eecs-448-battleship/blob/1c3ab08b1ac0621307e7af35c2ad064e9491836a/eecs-448-battleship/lib/js/view.js#L11)
was inspired by [Backbone.js](https://backbonejs.org/) (except, we simplified
and modernized it)
- String hashing algorithm copied from
Expand Down
8 changes: 4 additions & 4 deletions documentation/code-review.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,19 @@
For our team code review, we recursively explored the relevant views, components, and libraries as they appeared sequentially in the main game loop (the entry point can be found at (```views/CanvasView/script.js```). We also looked at the core loop logic, and discussed any optimizations that could be made as such. As we found present issues in the code iteslf or with gameplay funtionality, we took a deeper-dive into that issue and discussed ways to solve it. We proceeded to formally open each issue we found during the code review within Github.

## Issues
The [first issue](https://github.com/maxxxxxdlp/eecs-448-pixelland/issues/46) we found was with regards to the player position as the viewport changed size. The player position is supposed to always remain in the absolute center of the screen, and this bug presented itself by shifting the center coordinates when the viewport dimesnions change. Max made the inference that this could be fixed by shifting the cartesian plane's origin to the center of the screen, equal to the intended player position.
The [first issue](https://github.com/maxpatiiuk/eecs-448-pixelland/issues/46) we found was with regards to the player position as the viewport changed size. The player position is supposed to always remain in the absolute center of the screen, and this bug presented itself by shifting the center coordinates when the viewport dimesnions change. Max made the inference that this could be fixed by shifting the cartesian plane's origin to the center of the screen, equal to the intended player position.

We brainstormed ideas for what might have been causing this, and then Max went ahead and implemented a fix later down the line.

The [second issue](https://github.com/maxxxxxdlp/eecs-448-pixelland/issues/47) was more of a fundamental change (a 'nice to have') in the context of player movement. The original implementation of player movement was akin to the video game "Pokemon," where the player's movement was bound by the entire cell. It was impossible for you to move granularly between cells. This was a quality-of-life issue that we collectively decided would be worth-while to implement.
The [second issue](https://github.com/maxpatiiuk/eecs-448-pixelland/issues/47) was more of a fundamental change (a 'nice to have') in the context of player movement. The original implementation of player movement was akin to the video game "Pokemon," where the player's movement was bound by the entire cell. It was impossible for you to move granularly between cells. This was a quality-of-life issue that we collectively decided would be worth-while to implement.

Max had some specific ideas on how to improve the rendering by shifting cells and rendering the borders instead of redrawing the entire map each frame.

The [third issue](https://github.com/maxxxxxdlp/eecs-448-pixelland/issues/50) we discovered was with regards to saving and loading worlds. Our intended functionality of the save/load function was to be able to save and come back to the exact same world (RainbowLand, Minecraft, or otherwise). When testing this functionality, we discovered that saving an instance of RainbowLand and attempting to reload it would load a Minecraft world instead.
The [third issue](https://github.com/maxpatiiuk/eecs-448-pixelland/issues/50) we discovered was with regards to saving and loading worlds. Our intended functionality of the save/load function was to be able to save and come back to the exact same world (RainbowLand, Minecraft, or otherwise). When testing this functionality, we discovered that saving an instance of RainbowLand and attempting to reload it would load a Minecraft world instead.

Max was assigned this issue, and we discovered that the problem was that the current map type was not being remembered properly, and on top of that a random seed was being used for the reloading.

The [fourth issue](https://github.com/maxxxxxdlp/eecs-448-pixelland/issues/51) we found was during some performance testing. Within Pixelland is the ability to zoom in/out which, in essence, re-renders the map with a reduced/increased cell-size, allowing the same dimesnions of viewport to contain more cells (zooming out) or less cells (zooming in). When zooming out, there is a distinct reduction in performce as the game tries to redraw all of these new cells. We determined that this wasn't just an issue with zooming out, but spoke to a more general need for performance optimizations in the game as a whole. We decided it would be worth-while to prioritize the optimization of the rendering engine, so that the game is more playable for more people.
The [fourth issue](https://github.com/maxpatiiuk/eecs-448-pixelland/issues/51) we found was during some performance testing. Within Pixelland is the ability to zoom in/out which, in essence, re-renders the map with a reduced/increased cell-size, allowing the same dimesnions of viewport to contain more cells (zooming out) or less cells (zooming in). When zooming out, there is a distinct reduction in performce as the game tries to redraw all of these new cells. We determined that this wasn't just an issue with zooming out, but spoke to a more general need for performance optimizations in the game as a whole. We decided it would be worth-while to prioritize the optimization of the rendering engine, so that the game is more playable for more people.

As a group, we helped Max with performance testing as he implemented new optimizations.

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"license": "MIT",
"repository": {
"type": "git",
"url": "git://github.com/maxxxxxdlp/eecs-448-project-3"
"url": "https://github.com/maxpatiiuk/eecs-448-project-3"
},
"devDependencies": {
"@maxxxxxdlp/eslint-config": "^1.0.9",
Expand Down

0 comments on commit bf09a97

Please sign in to comment.