Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libglvnd 1.6.0 #748

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

libglvnd 1.6.0 #748

wants to merge 2 commits into from

Conversation

maxim-belkin
Copy link
Owner

Created with brew bump-formula-pr.

@maxim-belkin maxim-belkin added the Do not merge (yet) "Do not merge" label for PRs that must be shipped together with other changes label Jan 1, 2023
@maxim-belkin maxim-belkin mentioned this pull request Jan 2, 2023
Open
12 tasks
@maxim-belkin
libglvnd: fix meson arguments
6a6c961 
Replace `enabled` with `true`
@maxim-belkin
Copy link
Owner Author 

`brew linkage --test maxim-belkin/xorg/libglvnd` failed on Linux!

Unwanted system libraries:
  /lib/x86_64-linux-gnu/libGLX.so.0
  /lib/x86_64-linux-gnu/libGLdispatch.so.0

@sjackman, any advice here? These libs are, in fact, in the bottle.

@maxim-belkin
Copy link
Owner Author

@jonchang, any advice on the linkage test issue above (#748 (comment))?

@jonchang
Copy link
Collaborator

It looks like they're linking against the system libraries, though. Since it seems like you need system X installed in order to test the bottles, I wonder if it makes sense to split up the brew test-bot invocations to only build on a container without system X, then only test on a container with system X. I think this should be possible but it will involved some wrangling.

@jonchang
Copy link
Collaborator

Alternatively for formulae which need X installed to run their tests you could have a test-only dependency on a formula which has a null X device?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Do not merge (yet) "Do not merge" label for PRs that must be shipped together with other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxim-belkin @jonchang