create legal hold testcase #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
requested changes
Nov 26, 2024
There was a problem hiding this comment.
Thanks @Seyifunmi for submitting a PR! Overall looks good except for few comments.
To check if everything looks good locally:
- May run
deno task checkfor formatting and linting - May run
deno task validatewhich will return test cases to be created and whether all the changes are valid (in green) or throw an error (in red).
| @@ -0,0 +1,71 @@ | |||
| --- | |||
There was a problem hiding this comment.
Let's move this test case file to (new folder): data/test-cases/plugins/legal-hold to consolidate all plugins in a common folder.
Comment on lines
+3
to
+6
| name: " create a legal hold." | ||
| status: Approved | ||
| priority: Normal | ||
| folder: data/test-cases/legal-hold |
There was a problem hiding this comment.
Suggested change
| name: " create a legal hold." | |
| status: Approved | |
| priority: Normal | |
| folder: data/test-cases/legal-hold | |
| name: "Create a legal hold" | |
| status: Active | |
| priority: Normal | |
| folder: Legal Hold |
| priority: Normal | ||
| folder: data/test-cases/legal-hold | ||
| authors: "@Seyifunmi" | ||
| team_ownership: [] |
There was a problem hiding this comment.
Suggested change
| team_ownership: [] | |
| team_ownership: | |
| - Deployment Eng |
| cypress: null | ||
| detox: null | ||
| mmctl: null | ||
| playwright: true; |
There was a problem hiding this comment.
Suggested change
| playwright: true; | |
| playwright: in Production |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create Legal Hold Testcase
Is the feature in stable branch or under review?