-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the test cases for the Settings slash command and zoom icon action in app bar on MM. #160
Open
arush-vashishtha
wants to merge
2
commits into
mattermost:main
Choose a base branch
from
Brightscout:App_icon_and_slash_command
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
51 changes: 51 additions & 0 deletions
51
data/test-cases/plugins/zoom/general/Settings_slash_command.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
--- | ||
# (Required) Ensure all values are filled up | ||
name: "Settings slash command should not accept any arguments after `/zoom settings`" | ||
status: Active | ||
priority: Normal | ||
folder: General | ||
authors: "@arush-vashishtha" | ||
team_ownership: [] | ||
priority_p1_to_p4: P2 - Core Functions (Do core functions work?) | ||
|
||
# (Optional) | ||
location: null | ||
component: null | ||
tags: [] | ||
labels: [] | ||
tested_by_contributor: null | ||
|
||
# (Optional) Test type and tools | ||
cypress: null | ||
detox: null | ||
mmctl: null | ||
playwright: null | ||
rainforest: [] | ||
manual_test_environments: [] | ||
|
||
# Do not change | ||
id: null | ||
key: null | ||
created_on: null | ||
last_updated: null | ||
case_hashed: null | ||
steps_hashed: null | ||
--- | ||
|
||
**Step 1** | ||
|
||
1. Enter and run the slash command `/zoom` in any desired channel or DM/GM on MM. | ||
|
||
**Step 2** | ||
|
||
1. Enter and run the slash command `/zoom settings <command>` in any desired channel or DM/GM on MM. | ||
|
||
**Step 3** | ||
|
||
1. Enter and run the slash command `/zoom settings` in any desired channel or DM/GM on MM. | ||
|
||
**Expected** | ||
|
||
The suggested list of the commands should show the following suggestions in the desried channel or DM/GM on MM, `start [meeting topic]`, `connect`, `disconnect`, `settings` and `help`. | ||
After step 2, the user should get a message regarding the `unknown action` in the desired channel or DM/GM on MM. | ||
After step 3, the user should get the message regarding the use of Personal Meeting ID in the desired channel or DM/GM on MM. |
71 changes: 71 additions & 0 deletions
71
data/test-cases/plugins/zoom/general/Zoom_icon_in_app_bar.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
--- | ||
# (Required) Ensure all values are filled up | ||
name: "Creating meeting using Zoom icon in the app bar/channel header." | ||
status: Active | ||
priority: Normal | ||
folder: General | ||
authors: "@arush-vashishtha" | ||
team_ownership: [] | ||
priority_p1_to_p4: P2 - Core Functions (Do core functions work?) | ||
|
||
# (Optional) | ||
location: null | ||
component: null | ||
tags: [] | ||
labels: [] | ||
tested_by_contributor: null | ||
|
||
# (Optional) Test type and tools | ||
cypress: null | ||
detox: null | ||
mmctl: null | ||
playwright: null | ||
rainforest: [] | ||
manual_test_environments: [] | ||
|
||
# Do not change | ||
id: null | ||
key: null | ||
created_on: null | ||
last_updated: null | ||
case_hashed: null | ||
steps_hashed: null | ||
--- | ||
|
||
**Step 1** | ||
|
||
1. Connect your MM account to your Zoom account using the slash command `/zoom connect`. | ||
2. Set the Zoom setting by running the slash command `/zoom settings` to `Yes` for using Personal Meeting ID when creating a meeting. | ||
3. Click on the Zoom icon in the app bar/channel header when there is no recent Zoom meeting in the channel or DM/GM on MM. | ||
|
||
**Step 2** | ||
|
||
1. Connect your MM account to your Zoom account using the slash command `/zoom connect`. | ||
2. Set the Zoom setting by running the slash command `/zoom settings` to `No` for using Personal Meeting ID when creating a meeting. | ||
3. Click on the Zoom icon in the app bar/channel header when there is no recent Zoom meeting in the channel or DM/GM on MM. | ||
|
||
**Step 3** | ||
|
||
1. Connect your MM account to your Zoom account using the slash command `/zoom connect`. | ||
2. Set the Zoom setting by running the slash command `/zoom settings` to `Ask` for using Personal Meeting ID when creating a meeting. | ||
3. Click on the Zoom icon in the app bar/channel header when there is no recent Zoom meeting in the channel or DM/GM on MM. | ||
|
||
**Step 4** | ||
|
||
1. Connect your MM account to your Zoom account using the slash command `/zoom connect`. | ||
2. Create a meeting by running the slash command `/zoom start <meeting topic>` in any desired channel or DM/GM on MM. | ||
3. Click on the Zoom icon in the app bar/channel header in the desired channel or DM/GM on MM. | ||
|
||
**Step 5** | ||
|
||
1. Connect your MM account to your Zoom account using the slash command `/zoom connect`. | ||
2. Create a meeting by clicking the Zoom icon in the app bar/channel header in any desired channel or DM/GM on MM. | ||
3. Click on the Zoom icon in the app bar/channel header in the desired channel or DM/GM on MM. | ||
|
||
**Expected** | ||
|
||
The user should be navigated to the Zoom meeting with the Personal Meeting ID on Zoom. | ||
After step 2, the user should be navigated to the Zoom meeting with Unique Meeting ID on Zoom. | ||
After step 3, the user should get the slack attachment to select the type of meeting to create in the desired channel or DM/GM on MM. | ||
After step 4, the user should get the message about an already created Zoom meeting and should get the slack attachment with the option to select `Create New Meeting` or `Join Existing Meeting` in the desired channel or DM/GM on MM. | ||
After step 5, the user should get the message about an already created Zoom meeting and should get the slack attachment with the option to select `Create New Meeting` or `Join Existing Meeting` in the desired channel or DM/GM on MM. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like there should be a step added here before step 1. to confirm the out-of-the-box behavior.
The step would have the same result as 1. but it confirms that the existing behavior was preserved and the user does not need to explicitly set that they want their PMI used as this was the original default behavior that should have been preserved as well.