-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile drafts #8280
base: main
Are you sure you want to change the base?
Mobile drafts #8280
Conversation
/update-branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Rajat-Dabade
Most flows around
- Creating Draft in DM, GM, Channel, Threads, Private Chanel, under deleted thread ✅
- Sending Threads, Editing threads work as expected. ✅
There couple of flow I wanted to bring to your notice
-
On the Draft Screen, if we hit on Android's back button (not the back arrow of MM app) the app closes instead of going back to channels list page
-
Once all drafts are sent out from the draft page, we have an empty page looking like below. would it be nice to add a 'No drafts at the moment' icon, like in web app. @asaadmahmood thoughts?
Thank you @yasserfaraazkhan for reviewing the code.
Let me check on this.
I remember having an empty screen for the draft view, let me add it. |
Can you please review again? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Rajat-Dabade
just 1 last change, in below flow
Scenarios 1:
Steps:
- From Draft page, Edit a draft. Verify you are taken to the Channel/DM/GM
- Edit the Draft in the Channel
- Click on the
<
back Icon on the channel
This is taking user to Draft page
. should it take user to Channels List page?
Scenarios 2:
With above steps, if we edit draft message (without sending it) and Click back button, the draft message is not updated.
Screen.Recording.2024-11-19.at.12.16.41.AM.mov
Scenario 3:
- The User group Name is shown like below
on web app it show as below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, minor changes though.
@Rajat-Dabade Also one minor thing, clicking on the message in the drafts view should take you to the channel where that message is in drafts. |
Also @Rajat-Dabade the first time the user goes to the draft screen (with a single draft), we show this to him. |
Summary
Separate tab for Drafts in mobile.
Ticket Link
https://mattermost.atlassian.net/browse/MM-39356
Checklist
E2E iOS tests for PR
.Device Information
This PR was tested on: iOS version 17.5 (Both on iPhone and ipad)
Screenshots
Release Note
Note:
Will cover all the test case for this PR in separate PR.