Snyk SBOM #8249
Draft
Snyk SBOM #8249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,6 +47,14 @@ jobs: | |||
| path: Mattermost-unsigned.ipa | |||
| name: Mattermost-unsigned.ipa | |||
|
|
|||
| -name: ci/sbom-ios | |||
| uses: ./.github/actions/snyk-sbom | |||
| working-directory: ./ios | |||
There was a problem hiding this comment.
(echoing my comment in the ticket)
Will this be able to pick up JS dependencies from the root (package*.json)? Same question with android.
There was a problem hiding this comment.
It should.. npm will check in the parent folder if needed
There was a problem hiding this comment.
After checking with the generated SBOMs from @enzowritescode, the build-specific SBOMs did not contain npm packages. Here is the summary:
## sbom_ios.json
- purl (total) -- 178
- pkg:cocoapods -- 170
- pkg:swift -- 8
## sbom_android.json
- purl (total) -- 5953
- pkg:maven -- 5953
As compared to SBOM for the whole project:
## sbom.json
- purl (total) -- 7546
- pkg:gem -- 138
- pkg:npm -- 1120
- pkg:maven -- 6110
- pkg:cocoapods -- 170
- pkg:swift -- 8
saturninoabril
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Thanks @enzowritescode, LGTM. Left comment for my reference only.
|
Converting back to a draft while I discuss with Snyk the dependencies/lockfile issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Generate SBOM (software bill of materials ) on release
Ticket Link
https://mattermost.atlassian.net/browse/SEC-6362
Release Note