Use libc c_char strings to unblock builds for Arm64 #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use libc c_char references to defer to the platform char implementation rather than using signed char (i8).
This allows us to build on Arm64 platforms where char is unsigned.
ref:
https://stackoverflow.com/questions/47684111/make-string-type-compatible-with-arm/47684200
https://users.rust-lang.org/t/expected-const-i8-found-const-u8-for-c-function-pointer-waiting-for-a-const-char/2441
remacs/remacs#1393
etc.
Otherwise arm64 gets build errors such as:
Built and tested on Arm64 linux and x86_64 linux