Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close tags when user types </ #145

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Flatta
Copy link

@Flatta Flatta commented Mar 30, 2016

#143.

but I don't know which one is better for key mapping, '/' or '< /'

@mattberkowitz
Copy link
Owner

I would have a separate command and function for this, if nothing else for organizational purposes.

Other than that I'll run it through some testing and let you know what I find

@Flatta
Copy link
Author

Flatta commented Mar 31, 2016

Thank you for looking into this.

so, should I add an option that enables / disables this function?

@mattberkowitz
Copy link
Owner

I would definitely add an option for this.

As far as checking for "/" or "</" I think just "/" would be better, for example I could type "<", go elsewhere in the document and do stuff then come back and type "/". Also you're already checking that the character before the "/" is "<" in the function that executes

@Flatta
Copy link
Author

Flatta commented Apr 1, 2016

Thanks! I appreciate it.

I've just committed my changes and I left keymaps as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants