Integration tests for visitor id vs user id scenarios #22776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneudert
reviewed
Nov 22, 2024
mneudert
reviewed
Nov 22, 2024
| $this->trackAction($trackerDevice2, 'log-in', 'user 1'); | ||
|
|
||
| $this->assertCounts(2, 8, 2); | ||
| $this->assertVisitorIdsCount(2); // TODO - discuss with product that new device forms a new visit |
There was a problem hiding this comment.
Just to mention so we don't forget this detail here:
We do not get two visits with four actions each. The "log-in" action of the second device will be merged into the first visit, so we have one visit with five, and one visit with three actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.
Review