fix boolean to array deprecation notice when adding to report metadat…

…a processedMetrics array
matomo-org · Sep 18, 2024 · c9d47e3 · c9d47e3
1 parent ff4aa13
commit c9d47e3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/core/Plugin/Report.php b/core/Plugin/Report.php
@@ -1344,10 +1344,10 @@ private function isScopeSameOrSubsetOf(?string $scope, string $supersetScope): b
     private function getProcessedMetricsMetadata(): array
     {
         $metadata = [
-            'names' => $this->getProcessedMetrics(),
-            'formulas' => null,
-            'temporaryMetricAggregationTypes' => null,
-            'temporaryMetricSemanticTypes' => null,
+            'names' => $this->getProcessedMetrics() ?: [],
+            'formulas' => [],
+            'temporaryMetricAggregationTypes' => [],
+            'temporaryMetricSemanticTypes' => [],
         ];
 
         if (empty($this->processedMetrics)) {

diff --git a/plugins/Goals/Goals.php b/plugins/Goals/Goals.php
@@ -327,7 +327,7 @@ public function getReportMetadataEnd(&$reports, $info)
                 continue;
             }
 
-            if (empty($apiReportToUpdate)) { // TODO: remove after done debugging
+            if (!is_array($apiReportToUpdate)) { // TODO: remove after done debugging
                 throw new \Exception("found empty report at $index");
             }