Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set domain on OAuth1 token #25

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Set domain on OAuth1 token #25

merged 3 commits into from
Oct 5, 2023

Conversation

matin
Copy link
Owner

@matin matin commented Oct 5, 2023

Whatever domain is being used during the original login is the same one that should continue to be used with the OAuth1 token. This change saves the domain on the OAuth1 token to ensure the correct domain is using when loading from a saved token.

This closes #24, which addresses the issue that caused #21.

This change is fully backwards compatible. The domain is only configured if there's one that's saved. If none is saved, the prior behaviors continues.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (515933f) 100.00% compared to head (4a55056) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         1035      1036    +1     
=========================================
+ Hits          1035      1036    +1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
garth/auth_tokens.py 100.00% <100.00%> (ø)
garth/http.py 100.00% <100.00%> (ø)
garth/sso.py 100.00% <100.00%> (ø)
garth/version.py 100.00% <100.00%> (ø)
tests/conftest.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matin matin merged commit 43196b5 into main Oct 5, 2023
20 checks passed
@matin matin deleted the oauth_domain branch October 5, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add domain to OAuth 1 token
1 participant