Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage with Ecto 3.12 #109

Merged
merged 3 commits into from
Aug 18, 2024
Merged

Conversation

Gladear
Copy link
Contributor

@Gladear Gladear commented Aug 13, 2024

Fixes #108

  • update Ecto to 3.12, force its usage, this change isn't going to be retrocompatible
  • use Ecto's new :parametrized representation
  • update changelog to reflect this change. Should this be noted down as breaking change?

@Gladear Gladear changed the title fix with ecto 3.12 Fix usage with Ecto 3.12 Aug 13, 2024
@lleger
Copy link

lleger commented Aug 13, 2024

Thanks for this PR, can confirm it fixes the issue upgrading from Ecto 3.11.3 → 3.12.0.

@lleger
Copy link

lleger commented Aug 14, 2024

Just wanted to call out, I was looking at the issue that introduced this change here (elixir-ecto/ecto#4419), eventually they added Ecto.Type.parameterized?/2 to help, specifically mentioning this code: elixir-ecto/ecto#4488

@mathieuprog mathieuprog merged commit 4fb24f6 into mathieuprog:master Aug 18, 2024
7 checks passed
@coveralls
Copy link

coveralls commented Aug 18, 2024

Pull Request Test Coverage Report for Build 793aece67eda84cba2fbb70cd9aab638757452d4-PR-109

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 83.008%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/polymorphic_embed.ex 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
lib/polymorphic_embed.ex 1 82.04%
Totals Coverage Status
Change from base Build 68e54e0df69da37bc48bdc160c77579a59adbdb1: 0.0%
Covered Lines: 298
Relevant Lines: 359

💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 793aece67eda84cba2fbb70cd9aab638757452d4-PR-109

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 83.008%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/polymorphic_embed.ex 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
lib/polymorphic_embed.ex 1 82.04%
Totals Coverage Status
Change from base Build 68e54e0df69da37bc48bdc160c77579a59adbdb1: 0.0%
Covered Lines: 298
Relevant Lines: 359

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 793aece67eda84cba2fbb70cd9aab638757452d4-PR-109

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 83.008%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/polymorphic_embed.ex 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
lib/polymorphic_embed.ex 1 82.04%
Totals Coverage Status
Change from base Build 68e54e0df69da37bc48bdc160c77579a59adbdb1: 0.0%
Covered Lines: 298
Relevant Lines: 359

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ecto 3.12 breaks it for enum fields
4 participants