Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function_generators: evaluate_strictness: return 0 if function succeeded #167

Closed
wants to merge 2 commits into from
Closed

Conversation

nicola-lunghi
Copy link

If the [[ a =~ b]] comparison return false, the function returns false as well. This makes the script exit if I set the errexit options if the input are valid

This fixes issue #163

If the [[ a =~ b]] comparison return false, the function returns false as well.
This makes the script exit if I set the errexit options if the input are valid

This fixes issue #163
@matejak
Copy link
Owner

matejak commented Oct 3, 2022

Could you please extend your PR so it adds the corresponding check to the test suite?
AFAIK, your use case corresponds to e.g. setting set -e as in https://github.com/matejak/argbash/blob/master/tests/regressiontests/basic.m4. Would it be possible to extend that script, so it expands that offending code?

Thank you for your PR, and don't be shy to add your name to AUTHORS as well.

@nicola-lunghi
Copy link
Author

fixed in #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants