React__tabs-with-router #1003
Open
React__tabs-with-router #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Aug 23, 2023
src/components/TabsPage/TabsPage.tsx
Outdated
| </div> | ||
|
|
||
| <div className="block" data-cy="TabContent"> | ||
| {tabs.find(t => t.id === selectId) |
There was a problem hiding this comment.
You're using 'tabs.find' to check if the tab exists and then 'tabs.filter' to extract the tab. This can be optimized by just using 'tabs.find' and storing the result in a variable, which improves performance by reducing the number of iterations over the 'tabs' array.
src/components/TabsPage/TabsPage.tsx
Outdated
Comment on lines
21
to
22
| {tabs.map(tab => ( | ||
| <li |
There was a problem hiding this comment.
You can use a destructuring for tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO - https://Soi4An.github.io/react_tabs-with-router/