Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOYO header creation #5754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MOYO header creation #5754

wants to merge 1 commit into from

Conversation

NeustrVk
Copy link

@NeustrVk NeustrVk commented Nov 29, 2024 •
edited
Loading

DEMO LINK
TEST REPORT LINK

  • Header height is set in 1 place (for the links)
  • Content is vertically centered (for any header height)
  • CSS is used to show all letters in Uppercase (don't type them in HTML)
  • Logo is an image wrapped with a link
  • CSS Variable is used for a blue color
  • Pseudo-element is used for a blue line below the active link
  • Code follows all the Code Style Rules ❗️

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Nov 29, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your submission! 🎉 The code meets the core requirements and functions as expected. While there are a few minor issues, such as the use of the * selector in CSS and the href attribute value needing URL encoding, these do not significantly impact the functionality. Keep up the good work and consider these suggestions for future improvements! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/index.html
</li>
<li>
<a
href="#laptops&computers"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute value '#laptops&computers' contains an ampersand ('&'), which is not a valid character in a URL fragment. Consider replacing it with '%26' to ensure proper URL encoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeustrVk @mateacademy-ai-mentor