add task solution #5744
add task solution #5744
Conversation
Wolfofff
commented
Nov 27, 2024
Wolfofff
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve the pull request. The typo in the class name navigation__wraper should be corrected to navigation__wrapper to ensure consistency and proper styling. Additionally, the src property in the CSS is invalid and should be removed, as font imports should be handled in the HTML or with @import in CSS. Please make these changes, and feel free to reach out if you need any help! Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/index.html
Outdated
| </head> | ||
| <body> | ||
| <h1>Moyo header</h1> | ||
| <header class="navigation"> | ||
| <div class="navigation__wraper"> |
There was a problem hiding this comment.
There's a typo in the class name navigation__wraper. It should be navigation__wrapper to ensure consistency and avoid potential issues with CSS styling.
src/style.css
Outdated
| @@ -1,3 +1,82 @@ | |||
| body { | |||
| margin: 0; | |||
| font-family: Roboto, sans-serif; | |||
| src: url('https://fonts.googleapis.com/css?family=Roboto:500&display=swap'); | |||
There was a problem hiding this comment.
The src property is not valid in CSS and should be removed. Font imports should be handled in the HTML or using @import in CSS.
src/style.css
Outdated
| text-decoration: none; | ||
| } | ||
|
|
||
| .navigation__wraper { |
There was a problem hiding this comment.
There's a typo in the class name navigation__wraper. It should be navigation__wrapper to match the HTML and ensure the styles are applied correctly.
There was a problem hiding this comment.
Great job on addressing the previous issues! 🎉 Your code now meets the task requirements and constraints, and it's well-structured. Here are some key points from the review:
- Class Name Correction: You've corrected the typo in the class name to
navigation__wrapper, ensuring consistency between your HTML and CSS files. - Font Handling: The font imports are correctly handled, but consider using
<link>tags in HTML for better performance. - Semantic HTML: Your use of semantic tags like
<header>,<nav>, and<ul>is excellent, which enhances the readability and accessibility of your code. - Styling Consistency: The CSS is well-organized, and the styles are consistent with the HTML structure. The header stretches the full page width, and the content is vertically centered as required.
- Active Link Styling: The blue link with a line below is correctly styled using a pseudo-element, and the
data-qa="hover"attribute is added to the 4th link.
While the code is approved, please review the comments to further improve your code. Addressing critical issues, such as ensuring consistent class names and optimizing font imports, will help you avoid similar problems in the future. Keep up the great work, and continue learning from your experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
