Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SearchEvent proper return type hint #176

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Fix SearchEvent proper return type hint #176

merged 1 commit into from
Mar 20, 2024

Conversation

sauls
Copy link
Contributor

@sauls sauls commented Mar 20, 2024

I am using phpstan with strict rules and max level and this caught this slipped wrong type hint.

@alexander-schranz alexander-schranz merged commit 320ac89 into massiveart:2.8 Mar 20, 2024
6 checks passed
@alexander-schranz
Copy link
Member

@sauls Thank you!

@sauls sauls deleted the feature/search-event-typehint-fix branch March 21, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-schranz alexander-schranz alexander-schranz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sauls @alexander-schranz