Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile ahk2 project alongside main project #461

Merged
merged 16 commits into from
Aug 18, 2024
Merged

Conversation

mark-wiemer
Copy link
Member

@mark-wiemer mark-wiemer commented Aug 18, 2024

Progress on #453

  • Move ahk2 submodule to root directory
  • Update tsconfig to build ahk2 project alongside main project when running compile-ts
  • Revert to Node 20 for stability
  • Pin some types for compatibility with ahk2 project

@mark-wiemer

This comment was marked as duplicate.

mark-wiemer

This comment was marked as duplicate.

Copy link
Member Author

@mark-wiemer mark-wiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking as manual tests aren't passing

package.json Show resolved Hide resolved
@mark-wiemer mark-wiemer added this pull request to the merge queue Aug 18, 2024
@mark-wiemer
Copy link
Member Author

Basic manual tests pass, extension is at least activating

Merged via the queue into main with commit bd03fb4 Aug 18, 2024
3 checks passed
@mark-wiemer mark-wiemer deleted the users/markwiemer/connect branch August 18, 2024 15:52
@RaptorX RaptorX mentioned this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant