Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding extra options and increasing reproducibility #9

Open
wants to merge 48 commits into
base: main
Choose a base branch
from

Conversation

tinytyranid
Copy link

@tinytyranid tinytyranid commented Oct 11, 2022

We are currently implementing the susCovONT pipeline, during this we have noticed that for us some of the tools would not work together unless they all were a specific version. We also had some need for some extra options as our goal is to automate it and at the same time increase reproducibility while doing so.

These are the changes we have implemented:

  • Version of tools that work together are specified in install.sh to make initial setup a bit easier
  • The tag.json from Nextclade is now moved to retain the information of the Nextclade database/tag that was used (005_nextclade/nextclade-tag.json)
  • We have added some extra options while running the pipeline:
    • -y, --yes for running the pipeline non-interactively and give an automatic yes to all prompts
    • --nextclade_ver for specifying the Nextclade version one would want to use
    • --nextclade_data_ver for specifying the Nextclade database tag that one would like to use
    • --keep_pangolin_ver for running the pipeline without updating Pangolin
    • -u, --user-id for specifying the user id for running docker commands
    • We have also updated the help text of some of the options that were already present
    • While adding these options we have made sure that the defaults are as they were from before, so a user that was running the pipeline before does not have to change the commands they are using now
  • We have also done some small fixes that we have come across while implementing these changes

Thank you for the great work you have done on developing this pipeline!

Edit 03.11.2022

  • Added Dockerfile
  • Added a basic usage example using the Dockerimage
  • Added actions/ci for the docker

tinytyranid and others added 30 commits September 16, 2022 14:31
Reason: nextstrain/nextclade version 2+ is incompatible with the current
pipeline and will cause the pipeline to not be able to run
Have to be if not (X or Y) for it to work as intended
Record Nextclade and Pangolin versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant