-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding extra options and increasing reproducibility #9
Open
tinytyranid
wants to merge
48
commits into
marithetland:main
Choose a base branch
from
tinytyranid:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: nextstrain/nextclade version 2+ is incompatible with the current pipeline and will cause the pipeline to not be able to run
Merging develop into main
Have to be if not (X or Y) for it to work as intended
Feature/add options
Record Nextclade and Pangolin versions
Only temporarily to test that the docker actions works
Co-authored-by: marrip <martin.rippin@web.de>
Co-authored-by: marrip <martin.rippin@web.de>
Co-authored-by: marrip <martin.rippin@web.de>
Co-authored-by: marrip <martin.rippin@web.de>
Co-authored-by: ankjelst <54952194+ankjelst@users.noreply.github.com>
Feature/make dockerfile
…nt-handling Feature/update conda environment handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently implementing the susCovONT pipeline, during this we have noticed that for us some of the tools would not work together unless they all were a specific version. We also had some need for some extra options as our goal is to automate it and at the same time increase reproducibility while doing so.
These are the changes we have implemented:
install.sh
to make initial setup a bit easiertag.json
from Nextclade is now moved to retain the information of the Nextclade database/tag that was used (005_nextclade/nextclade-tag.json
)-y, --yes
for running the pipeline non-interactively and give an automatic yes to all prompts--nextclade_ver
for specifying the Nextclade version one would want to use--nextclade_data_ver
for specifying the Nextclade database tag that one would like to use--keep_pangolin_ver
for running the pipeline without updating Pangolin-u, --user-id
for specifying the user id for running docker commandsThank you for the great work you have done on developing this pipeline!
Edit 03.11.2022