Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support algo options #217

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

EyePulp
Copy link

@EyePulp EyePulp commented Oct 26, 2023

Howdy;
I needed to adjust an algo via extra options, so I added support via an algoOptions object to pass through for the second argument -- crypto.createHash(algorithm[, options])

Added a test and updated readme docs, bumped the package.json version.

Let me know if I can improve anything!

Thanks for a cool package.

@EyePulp
Copy link
Author

EyePulp commented Oct 26, 2023

Looks like Node 10 allows the options to be passed (for shake256 for example) but ignores them. I added explicit CI tests for node12, and 14, which all seem to pass. The support for algorithm args wasn't added to createHash until node v12.8

I added a fix for the versions < v12.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant