Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json object loads is sometimes bytes object fix. #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Json object loads is sometimes bytes object fix. #4

wants to merge 1 commit into from

Conversation

Berghopper
Copy link

There was an issue I had regarding blockcrafter;

I got weird errors that json.loads was expecting str not bytes, I fixed the issue with the following commit.

This happened when trying to make a blockset of texture size 6 for mc 1.13.

Also, another note; PyQt 4 and 5 give me segmentation faults, however, pyglet seems to work well. I tested this with python3.4, I am not sure if blockcrafter works for 3.5 anymore...

@m0r13
Copy link
Member

m0r13 commented Nov 5, 2018

Just because I'm curious, which version of Python are you running?

@m0r13
Copy link
Member

m0r13 commented Nov 5, 2018

It's weird that people seem to have problems with the different backends of the vispy framework I'm using for all the OpenGL stuff, vispy should handle this correctly. We should maybe open a separate issue for that and discuss how what hints etc. we should give to users make a proper installation of Blockcrafter easier.

@ligos
Copy link

ligos commented Nov 5, 2018

I've got a Blockcrafter docs page in the works, to step people through the install bits. FYI, I had PyQt5 and Pyglet working on Ubuntu 18.04 and Windows 10 + Python 3.7.

I've seen various errors when Blockcrafter finishes rendering: stack traces are all about destructors and clean up. But the images / json files were still generated correctly.

@Berghopper
Copy link
Author

It's weird that people seem to have problems with the different backends of the vispy framework I'm using for all the OpenGL stuff, vispy should handle this correctly. We should maybe open a separate issue for that and discuss how what hints etc. we should give to users make a proper installation of Blockcrafter easier.

I do agree that we should definitely open a new issue on this, I do however want to note I have 0 experience in OpenGL stuff. I wouldn't mind learning this and helping to debug though :)

Btw, the specific version I was running;

python3.4.9

With the following libraries;

chardet==3.0.4
future==0.17.1
numpy==1.15.3
Pillow==5.3.0
pkg-resources==0.0.0
pyglet==1.3.2
vispy==0.5.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants