Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import externally generated files on Muon ALC interface #38398

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

robertapplin
Copy link
Contributor

@robertapplin robertapplin commented Nov 14, 2024

Report to: Adam Berlie

Description of work

This PR makes it possible to import a workspace from the ADS into the Muon ALC interface if it has 1 histogram. The data can be loaded into Mantid from a *.dat or *.txt file for example, and then imported into the Muon ALC interface as long as its a matrix workspace.

Fixes #38353

To test:

  1. Load the following data
    QLCR150K.zip

  2. Open Muon->ALC interface

  3. Click Import results... in the bottom left

  4. Enter the name of the workspace and click Okay

  5. The plot should be populated with the data

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@robertapplin robertapplin added Muon Issues and pull requests related to muons ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS labels Nov 14, 2024
@robertapplin robertapplin added this to the Release 6.12 milestone Nov 14, 2024
@robertapplin
Copy link
Contributor Author

I will send this package to Adam Berlie for testing:
https://builds.mantidproject.org/job/build_packages_from_branch/947/

@github-actions github-actions bot added the Has Conflicts Used by the bot to label pull requests that have conflicts label Nov 15, 2024
Copy link

👋 Hi, @robertapplin,

Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

@robertapplin robertapplin force-pushed the 38353-load-external-files-on-muon-alc branch from e0f2ee6 to 9cb74c8 Compare November 15, 2024 11:12
@robertapplin robertapplin removed the Has Conflicts Used by the bot to label pull requests that have conflicts label Nov 15, 2024
@robertapplin robertapplin force-pushed the 38353-load-external-files-on-muon-alc branch from 9cb74c8 to 1be816f Compare November 15, 2024 11:49
@robertapplin robertapplin marked this pull request as ready for review November 26, 2024 15:32
@robertapplin
Copy link
Contributor Author

Adam is happy with the changes:

Your new update to the ALC import worked well! I could load in my .dat file and analyse it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Muon Issues and pull requests related to muons
Projects
Status: Unassigned
Development

Successfully merging this pull request may close these issues.

Muon ALC interface ability to load externally generated files
1 participant