Refactor the Stretch tab in BayesFitting to meet MVP design pattren #38388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedAlmaki
added
Indirect/Inelastic
MohamedAlmaki
force-pushed
the
38005_mvp_stretch
branch
from
1460594
to
1be5945
Compare
MohamedAlmaki
force-pushed
the
38005_mvp_stretch
branch
4 times, most recently
from
941c3c8
to
193fe5d
Compare
MohamedAlmaki
force-pushed
the
38005_mvp_stretch
branch
from
193fe5d
to
95b8049
Compare
robertapplin
requested changes
Nov 27, 2024
| @@ -45,6 +45,8 @@ class MANTIDQT_INELASTIC_DLL BayesFitting : public InelasticInterface { | |||
| void initLayout() override; | |||
|
|
|||
| private: | |||
| std::unique_ptr<MantidQt::API::AlgorithmRunner> createAlgorithmRunner(); | |||
There was a problem hiding this comment.
Can this function be const?
Comment on lines
+53
to
+55
| auto filename = saveDir + wsName + ".nxs"; | ||
| if (filename.empty()) | ||
| saveProps->setProperty("Filename", wsName + ".nxs"); |
There was a problem hiding this comment.
I believe the filename parameter will never be empty because it always has + ".nxs" added to the end even if the save directory or workspace name is empty
|
|
||
| void StretchView::setSaveResultEnabled(bool enabled) { m_uiForm.pbSave->setEnabled(enabled); } | ||
|
|
||
| int StretchView::displaySaveDirectoryMessage() { |
There was a problem hiding this comment.
Can this return type be bool? I think at the moment its doing an implicit cast from bool to int
Comment on lines
+66
to
+67
| StretchView *m_view; | ||
| std::unique_ptr<StretchModel> m_model; |
There was a problem hiding this comment.
I think we want both of these to be an IStretchView and an IStretchModel, so that our tests can use the mock versions of our classes
| class MANTIDQT_INELASTIC_DLL StretchPresenter : public BayesFittingTab, public IStretchPresenter { | ||
|
|
||
| public: | ||
| StretchPresenter(QWidget *parent, StretchView *view, std::unique_ptr<StretchModel> model, |
There was a problem hiding this comment.
We also want these arguments to be an IStretchView and IStretchModel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This pull request replaces the old single-class Stretch tab with new model, presenter, and view classes to follow the MVP pattern. The goal of this work is to modernize the current codebase of the tab and adhere to best design practices.
Fixes #38005.
To test:
Follow the manual testing documentation and try to test multiple scenarios: https://developer.mantidproject.org/Testing/Inelastic/BayesFittingTests.html
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.