Remove direct calls to presenter from cut viewer view #38197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: JackEAllen <jack.allen@stfc.ac.uk> Co-authored-by: samtygier-stfc <sam.tygier@stfc.ac.uk> Co-authored-by:Adriazalvarez<Adrian.diaz-alvarez@stfc.ac.uk>
Co-authored-by: JackEAllen <jack.allen@stfc.ac.uk> Co-authored-by: samtygier-stfc <sam.tygier@stfc.ac.uk> Co-authored-by:Adriazalvarez<Adrian.diaz-alvarez@stfc.ac.uk>
Co-authored-by: JackEAllen <jack.allen@stfc.ac.uk> Co-authored-by: samtygier-stfc <sam.tygier@stfc.ac.uk> Co-authored-by:Adriazalvarez<Adrian.diaz-alvarez@stfc.ac.uk>
Co-authored-by: JackEAllen <jack.allen@stfc.ac.uk> Co-authored-by: samtygier-stfc <sam.tygier@stfc.ac.uk> Co-authored-by: Adriazalvarez <Adrian.diaz-alvarez@stfc.ac.uk>
RichardWaiteSTFC
added
the
ISIS Team: Core
Co-authored-by: JackEAllen <jack.allen@stfc.ac.uk> Co-authored-by: samtygier-stfc <sam.tygier@stfc.ac.uk> Co-authored-by: Adriazalvarez <Adrian.diaz-alvarez@stfc.ac.uk> Also made explicit `representation_params` returned and passed to various methods
Co-authored-by: JackEAllen <jack.allen@stfc.ac.uk> Co-authored-by: samtygier-stfc <sam.tygier@stfc.ac.uk> Co-authored-by: Adriazalvarez <Adrian.diaz-alvarez@stfc.ac.uk>
RichardWaiteSTFC
force-pushed
the
38102_view_not_to_call_presenter_methods_directly
branch
from
44725f4
to
b111316
Compare
This involved refactoring cut representation to work only with basis vectors, extents etc. in the 2D slice - so as to avoid having to retrieve 3rd integrated dim from view in update_bin_params_from_cut_representation Also updated tests and fixed failing test
|
I think this needs rebasing on main now that the prior PR has been merged. When its rebased I will review! |
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @RichardWaiteSTFC, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Remove direct calls to presenter from cut viewer view for MVP training.
This is blocked by #38101(which must be merged first)
Fixes #38102
To test:
(1) Follow manual testing instructions
https://developer.mantidproject.org/Testing/SliceViewer/SliceViewer.html#cutviewer-tool
This does not require release notes because internal change, users shouldn't notice difference
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.