Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video/tmep038.cpp: Use device_gfx_interface for gfx decode, Fix notes #13019

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cam900
Copy link
Contributor

@cam900 cam900 commented Nov 26, 2024

atlus/cave.cpp: Reduce duplicates

Copy link
Member

@cuavas cuavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look OK, but is it really a win in this case?

  • The 038 tilemap device doesn’t use a fixed tile format, so the actual graphics decoding layout still needs to be supplied by the user.
  • It seems to require more configuration this way than it did before.
  • If multiple chips use the same tiles, they’ll end up with duplicated copies of the decoded tiles.

Overall, this doesn’t look like a clear improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants