Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

micromamba/mamba --version displays pre-release version names + establishes pre-release versions name scheme #3639

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Klaim
Copy link
Member

@Klaim Klaim commented Nov 27, 2024

Part of the effort for #3638

While I started this just to allow displaying the pre-release versions in micromamba/mamba --version, this required also changing the release scripts to provide the relevant information to the source code. As part of that change I setup the discussed pre-release version naming scheme with validation in the release scripts.

Also deprecates mamba::version_arr() and umamba::version_arr() functions which seem unusued. If there is a need for information about the version, I'll add another more precise function as a replacement, or we'll just remove these.

@Klaim Klaim added the release::enhancements For enhancements PRs or implementing features label Nov 27, 2024
@Klaim Klaim self-assigned this Nov 27, 2024
@Klaim Klaim marked this pull request as ready for review November 28, 2024 14:51
@Klaim
Copy link
Member Author

Klaim commented Nov 29, 2024

Note that this version accepts a minimum of 3 dot-separated fields but does not limit the number of dots over 3, so schemes with and without additional dots are considered "valid" by the validation script.

)
)

VALID_VERSION_PRERELEASE_TYPES = ("alpha", "beta")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about rc and dev?

@Hind-M
Copy link
Member

Hind-M commented Dec 2, 2024

Adding this as a reference.

@jjerphan
Copy link
Member

jjerphan commented Dec 2, 2024

Adding this as a reference.

This piece of conda.models.VersionOrder's docstring is also relevant (it is linked in the section Hind shared).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::enhancements For enhancements PRs or implementing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants