maint: Move solver::libsolv::parameters to solver::parameters
#3378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
force-pushed
the
maint/move-libsolv-parameters-up
branch
from
75d466c
to
b7de98f
Compare
jjerphan
commented
Aug 1, 2024
There was a problem hiding this comment.
New lines come from libmambapy/src/libmambapy/bindings/solver_libsolv.cpp with no modifications.
Comment on lines
+15
to
+19
| _WARN_TEMPLATE_MSG = ( | ||
| "`libmambapy.bindings.solver.libsolv.{name}` has been moved " | ||
| "to `libmambapy.bindings.solver.{name}` in 2.0. " | ||
| "This import path will be removed in 2.2" | ||
| ) |
There was a problem hiding this comment.
Is there a preferred way of deprecating import path?
libmambapy/tests/test_solver.py
Outdated
There was a problem hiding this comment.
New lines come from libmambapy/tests/test_solver_libsolv.py with no modifications.
jjerphan
force-pushed
the
maint/move-libsolv-parameters-up
branch
from
caf5cc1
to
8b2f74a
Compare
24 tasks
jjerphan
added
type::refactoring
release::enhancements
jjerphan
force-pushed
the
maint/move-libsolv-parameters-up
branch
from
8b2f74a
to
4cde652
Compare
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
force-pushed
the
maint/move-libsolv-parameters-up
branch
from
4cde652
to
1f4a1c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.