Added flag for main domain as SAN #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wimmme
reviewed
Jan 29, 2024
| echo "INFO: Main domain SAN requested and will be created at the same time" | ||
| LETSENCRYPT_WILDCARD_DOMAIN_SAN="true" | ||
| else | ||
| LETSENCRYPT_WILDCARD_DOMAIN_SAN="true" |
There was a problem hiding this comment.
don't see the logic if the outcame is always LETSENCRYPT_WILDCARD_DOMAIN_SAN="true" ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows one to add multiple domains for the cert allowing for SANs (so I can do wildcard subdomains and main domain with the same cert).