Implemented APIKeys, as well as getting to conform to check style #2
Conversation
jecortez
force-pushed
the
APIKeyImpl_Client
branch
2 times, most recently
from
391312e
to
e9f4a38
Compare
jecortez
force-pushed
the
APIKeyImpl_Client
branch
2 times, most recently
from
da1d81f
to
bad94fc
Compare
| @PUT | ||
| @Path("/{id}/password") | ||
| public Response updateUserPassword(@PathParam("id") long id, String password) { | ||
| public Response updateUserPassword(@Auth ApiKey key, | ||
| @PathParam("id") long id, String password) { |
There was a problem hiding this comment.
nit: newline the String password?
|
One point to discuss. @bbeck had previously brought up the question with me on whether or not we want to have references to mysql or any other db in the base project. The consensus at the time was no since folks leveraging this template could use MySQL, Mongo, DynamoDB or whatever. So would it be better to remove the project dependencies on mysql? |
jecortez
force-pushed
the
APIKeyImpl_Client
branch
3 times, most recently
from
c58b03f
to
6d4140b
Compare
| <source>1.8</source> | ||
| <target>1.8</target> | ||
| <compilerArgs> | ||
| <arg>-parameters</arg> |
There was a problem hiding this comment.
java 8 parameters name support. Makes using Jackson way easier (no more JsonProperty unless you want to use a different name)
There was a problem hiding this comment.
This should only be added if its needed though.
There was a problem hiding this comment.
Ahh, gotcha. And I agree on only adding it where it's needed.
|
I +1 JB's comment about DBs above. Also would be nice if PRs were smaller, single purpose changes. Much easier to read that way vs doing 3 things at once. |
jecortez
force-pushed
the
APIKeyImpl_Client
branch
from
6d4140b
to
2c8cc5d
Compare
|
@jecortez this is great stuff. are you ready to merge? lgtm. |
No description provided.