Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ->>as-> function for use with ->> #411

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zardoz03
Copy link

@zardoz03 zardoz03 commented Dec 5, 2023

seems better and more consistent to use

(->> 1 (->>as-> i (+ i 1)))

rather than

(->> 1 ((lambda (i) (+ i 1)))

+ there's less consing of misc. closures to mimic the same functionality as -as->

@zardoz03
Copy link
Author

zardoz03 commented Dec 5, 2023

I will apply for GNU copyright assignment when I can; hopefully by end of day

Copy link
Collaborator

@basil-conto basil-conto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I won't be able to review this for a few days, so just a quick comment from me in the meantime.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this file is auto-generated from the docstrings in dash.el and the first three examples in dev/examples.el.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So i'd have to rewrite the tests in order for it to work?
I didn't notice that when I was writing sorry.

Also I forgot to email FSF because other things cropped up -- shall have to ask about anonymous assignments + maybe PO boxes.

Copy link
Collaborator

@basil-conto basil-conto Dec 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So i'd have to rewrite the tests in order for it to work?

The first three tests in dev/examples.el should be self-contained and representative, then make docs regenerates both README.md and dash.texi accordingly.

If you have any difficulties or would rather avoid running make docs on your end, that's no problem, one of the maintainers or I can do so on the PR branch before merging.

I didn't notice that when I was writing sorry.

No problem at all.

Also I forgot to email FSF because other things cropped up -- shall have to ask about anonymous assignments + maybe PO boxes.

Good luck! Keep us posted.

@basil-conto basil-conto added enhancement Suggestion to improve or extend existing behavior copyright Waiting for FSF copyright assignment labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
copyright Waiting for FSF copyright assignment enhancement Suggestion to improve or extend existing behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants