Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken Bundle and Downloadable product pages layout in Magento >= 2.4.7 #39391

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

vovayatsyuk
Copy link
Member

@vovayatsyuk vovayatsyuk commented Nov 21, 2024

Description (*)

This PR fixes the broken layout on the bundle and downloadable product pages. This issue caused by rearranging of product.info.media block in Magento 2.4.7

Without PR With PR

Related Pull Requests

  • PR that caused the issue: 9b224ac

Manual testing scenarios (*)

  1. Open the bundle product page and check the layout on the desktop. (Gear > Fitness Equipment > Sprite Yoga Companion Kit)
  2. Add bundle product page to the wishlist, navigate to the wishlist, click on the edit icon, and check the layout.
  3. Repeat the same two steps for the downloadable product.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fixed broken Bundle and Downloadable product pages layout in Magento >= 2.4.7 #39403: Fixed broken Bundle and Downloadable product pages layout in Magento >= 2.4.7

Copy link

m2-assistant bot commented Nov 21, 2024

Hi @vovayatsyuk. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Hotel
Copy link
Contributor

@magento create issue

@engcom-Hotel engcom-Hotel added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: pending review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Fixed broken Bundle and Downloadable product pages layout in Magento >= 2.4.7
2 participants