Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSK] Implement Grab the Prize #13049

Merged
merged 5 commits into from
Oct 31, 2024
Merged

[DSK] Implement Grab the Prize #13049

merged 5 commits into from
Oct 31, 2024

Conversation

Jamaninja
Copy link
Contributor

@Jamaninja Jamaninja commented Oct 29, 2024

Part of #12534

@github-actions github-actions bot added the cards label Oct 29, 2024
Copy link
Member

@JayDi85 JayDi85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine, only one comment miss

// Draw two cards.
this.getSpellAbility().addEffect(new DrawCardSourceControllerEffect(2));

this.getSpellAbility().addEffect(new ConditionalOneShotEffect(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miss comment with full ability text

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this was my first card. Should I include the comment in a commit the next time I upload a card?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can edit and add commit to your version, it will be available in that PR too.

@JayDi85 JayDi85 merged commit 0853ac8 into magefree:master Oct 31, 2024
3 checks passed
@JayDi85
Copy link
Member

JayDi85 commented Oct 31, 2024

Thank you for PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants