Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TW-996: Fix epic NFT update #962

Merged
merged 146 commits into from
Nov 1, 2023
Merged

TW-996: Fix epic NFT update #962

merged 146 commits into from
Nov 1, 2023

Conversation

alex-tsx
Copy link
Collaborator

@alex-tsx alex-tsx commented Oct 4, 2023 •
edited
Loading

Task: https://madfish.atlassian.net/browse/TW-996

Scenario:

  • Fresh install, importing tz1XQzfabXm4LZNKnok6W41rdp35qYbti9uE by Seed Phrase.
  • Waiting till all tokens are loaded with icons
  • Switching to NFT screen
  • Waiting till all collectibles loaded with images

Number of Wallet screen renders (entering functional component):

  • development: 75
  • TW-996-fix-epic-nft-update: 25

Boltman92 and others added 30 commits April 4, 2023 10:37
@Boltman92
add new header for nft page
dba8b1a
@Boltman92
fix conflicts with dev
2ec8446
@Boltman92
fix test errors
381d469
@Boltman92
refactoring after review
c4895c7
@Boltman92
fix icons color and disabled social links
5fbc240
@Boltman92
refactoring way how to save collection info
9d8bbb6
@Boltman92
add collection logo fallback
3cd6bdd
@Boltman92
refactoring variables naming
f914baa
@Boltman92
add icon for broken images in collections
af09232
@Boltman92
merge with dev
efc23a0
@Boltman92
add styling for broken collections
e1b6a13
@Boltman92
fix error handling for images in collections
b872ef6
@Boltman92
fix mock file
527caae
@Boltman92
fix test errors
51d7316
@Boltman92
fix after review
772662b
@Boltman92
fix conflicts
09d9ae3
@Boltman92
revert cocoapods version
2a8518f
@Boltman92
Tw 579/nft-section (#788)
f8b0a34
@Boltman92
merge with dev
64d2dd7
@Boltman92
empty commit for fix
fa545de
@Boltman92
fix conflicts
0dcfb1d
@Boltman92
fix conflicts
812e618
@Boltman92
fix comments
5e52d15
@Boltman92
fix styles bugs
0834ea7
@Boltman92
resolve merge conflicts
9a6da42
@Boltman92
revert file structure
a166c0f
@Boltman92
integrate tz profiles (#789)
311a354
@Boltman92
fix styles, cache and other
3a9bb99
@Boltman92
fix merge conflicts
7baac5a
@Boltman92
delete useless react fragment
ca18a28
@alex-tsx alex-tsx force-pushed the TW-996-fix-epic-nft-update branch 2 times, most recently from 90d13ab to 9370e87 Compare October 30, 2023 21:24
@alex-tsx alex-tsx temporarily deployed to testapp October 30, 2023 21:43 — with GitHub Actions Inactive
@alex-tsx alex-tsx temporarily deployed to testapp October 31, 2023 10:08 — with GitHub Actions Inactive
keshan3262
keshan3262 previously approved these changes Oct 31, 2023
View reviewed changes
lendihop
lendihop previously approved these changes Oct 31, 2023
View reviewed changes
@alex-tsx
Copy link
Collaborator Author

Build: https://github.com/madfish-solutions/templewallet-mobile/actions/runs/6704985021

lourenc
lourenc previously approved these changes Oct 31, 2023
View reviewed changes
IrynaKhyzhynska
IrynaKhyzhynska previously approved these changes Nov 1, 2023
View reviewed changes
Copy link

@IrynaKhyzhynska IrynaKhyzhynska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

android done 1.16_1005

tttt24
tttt24 previously approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@tttt24 tttt24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ios done: 1.16_1005

@alex-tsx alex-tsx changed the base branch from TW-626-epic-nft-update to development November 1, 2023 13:37
@alex-tsx alex-tsx dismissed stale reviews from tttt24, IrynaKhyzhynska, lourenc, lendihop, and keshan3262 November 1, 2023 13:37

The base branch was changed.

@lourenc lourenc merged commit f7f5d9d into development Nov 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lendihop lendihop lendihop approved these changes

@keshan3262 keshan3262 keshan3262 approved these changes

@lourenc lourenc lourenc approved these changes

@tttt24 tttt24 tttt24 left review comments

@IrynaKhyzhynska IrynaKhyzhynska IrynaKhyzhynska left review comments

Assignees

@alex-tsx alex-tsx

Labels
qa approved
Projects
None yet
Milestone
TW-626: [epic] NFT update
Development

Successfully merging this pull request may close these issues.
9 participants
@alex-tsx @lourenc @keshan3262 @IrynaKhyzhynska @lendihop @tttt24 @Boltman92 @svjatoslavtt @herkoss