Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TW-786 Refactored transaction history for send, receive and delegate #884

Merged
merged 30 commits into from
Aug 29, 2023
Merged

TW-786 Refactored transaction history for send, receive and delegate #884

merged 30 commits into from
Aug 29, 2023

Conversation

herkoss
Copy link
Contributor

@herkoss herkoss commented Jul 17, 2023

No description provided.

@herkoss herkoss self-assigned this Jul 17, 2023
keshan3262
keshan3262 previously approved these changes Jul 18, 2023
View reviewed changes
lendihop
lendihop previously approved these changes Jul 18, 2023
View reviewed changes
@vladvn1905 vladvn1905 temporarily deployed to testapp July 19, 2023 06:11 — with GitHub Actions Inactive
@herkoss herkoss dismissed stale reviews from lendihop and keshan3262 via f3f1070 July 27, 2023 10:39
lendihop
lendihop previously approved these changes Jul 27, 2023
View reviewed changes
keshan3262
keshan3262 previously approved these changes Jul 27, 2023
View reviewed changes
lendihop
lendihop previously approved these changes Jul 27, 2023
View reviewed changes
@tttt24 tttt24 temporarily deployed to testapp July 27, 2023 12:41 — with GitHub Actions Inactive
@herkoss herkoss dismissed stale reviews from lendihop and keshan3262 via f58b554 July 31, 2023 17:09
keshan3262
keshan3262 previously approved these changes Aug 1, 2023
View reviewed changes
lendihop
lendihop previously approved these changes Aug 1, 2023
View reviewed changes
@vladvn1905 vladvn1905 temporarily deployed to testapp August 1, 2023 08:45 — with GitHub Actions Inactive
@herkoss herkoss dismissed stale reviews from keshan3262 and alex-tsx via 710ccfe August 16, 2023 10:53
keshan3262
keshan3262 previously approved these changes Aug 16, 2023
View reviewed changes
@alex-tsx alex-tsx self-requested a review August 16, 2023 11:49
alex-tsx
alex-tsx previously approved these changes Aug 17, 2023
View reviewed changes
src/utils/token-operations.util.ts Show resolved Hide resolved
@tttt24 tttt24 temporarily deployed to testapp August 17, 2023 14:36 — with GitHub Actions Inactive
@herkoss herkoss dismissed stale reviews from alex-tsx and keshan3262 via b1d9319 August 23, 2023 13:41
@alex-tsx alex-tsx self-requested a review August 25, 2023 10:57
alex-tsx
alex-tsx reviewed Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@alex-tsx alex-tsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to stop working with matrix data type, i.e. ActivityGroup[] = Activity[][]

src/hooks/use-contract-activity.ts Outdated Show resolved Hide resolved
src/hooks/use-contract-activity.ts Outdated Show resolved Hide resolved
src/hooks/use-contract-activity.ts Outdated Show resolved Hide resolved
src/components/activity-groups-list/activity-groups-list.tsx Outdated Show resolved Hide resolved
@herkoss @alex-tsx
Update src/hooks/use-contract-activity.ts
5cec3e2 
Co-authored-by: Alex <alex.seleznov@gmail.com>
@herkoss herkoss requested a review from alex-tsx August 28, 2023 08:23
@IrynaKhyzhynska IrynaKhyzhynska temporarily deployed to testapp August 28, 2023 11:17 — with GitHub Actions Inactive
tttt24
tttt24 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@tttt24 tttt24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ios done 1.16_900

IrynaKhyzhynska
IrynaKhyzhynska approved these changes Aug 29, 2023
View reviewed changes
Copy link

@IrynaKhyzhynska IrynaKhyzhynska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

android done 1.16_900

@herkoss herkoss changed the base branch from development to transaction-history-epic August 29, 2023 10:39
@lourenc lourenc merged commit 71bc295 into transaction-history-epic Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tttt24 tttt24 tttt24 approved these changes

@alex-tsx alex-tsx alex-tsx approved these changes

@IrynaKhyzhynska IrynaKhyzhynska IrynaKhyzhynska approved these changes

@keshan3262 keshan3262 keshan3262 approved these changes

@lendihop lendihop Awaiting requested review from lendihop

Assignees

@herkoss herkoss

Labels
qa approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@herkoss @keshan3262 @IrynaKhyzhynska @lendihop @alex-tsx @tttt24 @lourenc @vladvn1905