Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply kn007 ocsp stapling patch #116

Closed
wants to merge 3 commits into from

Conversation

natsl05164
Copy link

Ran the dockerfile with the KN007 Enable_BoringSSL_OCSP.patch without error. However i didn't make a test on real https domain..
The KN007 patch is It adds OCSP stapling support for BoringSSL to Nginx using the ssl_stapling_file parameter. However the ssl_stapling_file (/path/to/ocsp.resp) needs to be renewed from the issuer site every fixed duration and the response will be saved to (/path/to/ocsp.resp) which is what the cron job does. You may see the details given on KN007's blog https://kn007.net/topics/let-nginx-support-ocsp-stapling-when-using-boringssl/. Thanks

@macbre
Copy link
Owner

macbre commented Sep 17, 2023

Tests are failing with:

2023-09-17T12:10:13.7923577Z 2023/09/17 12:10:13 [notice] 1#1: using boringssl, currently only "ssl_stapling_file" is supported. use it as your own risk
2023-09-17T12:10:13.7928916Z 2023/09/17 12:10:13 [emerg] 1#1: BIO_new_file("/path/to/ocsp.resp") failed (SSL: error:02000002:system library:OPENSSL_internal:No such file or directory:fopen('/path/to/ocsp.resp','r') error:1100006e:BIO routines:OPENSSL_internal:NO_SUCH_FILE)

@macbre
Copy link
Owner

macbre commented Sep 18, 2023

I do not think that the approach with the cronjob setup will work for most users of this container. Hence...

  1. Let's keep the patch being applied in the Dockerfile.
  2. Comment out the ssl_stapling_file /path/to/ocsp.resp; field from the test config.
  3. Move the tests/oscp.cron.sh file content to a README file describing how to set up the OCSP stapling (i.e. obtaining the OCSP reply from the certificate issuer).

@macbre macbre marked this pull request as draft September 18, 2023 11:25
Copy link

github-actions bot commented Aug 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the wontfix This will not be worked on label Aug 5, 2024
Copy link

github-actions bot commented Nov 3, 2024

Closing this due to being stale.

@github-actions github-actions bot closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants