Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #204 - Mounting nexus.properties in a ConfigMap #212

Merged
merged 6 commits into from
Aug 17, 2021
Merged

Closes #204 - Mounting nexus.properties in a ConfigMap #212

merged 6 commits into from
Aug 17, 2021

Conversation

ricardozanini
Copy link
Member

@ricardozanini ricardozanini commented Jun 13, 2021 •
edited
Loading

Signed-off-by: Ricardo Zanini ricardozanini@gmail.com

closes #204

@ricardozanini
Closes #204 - Mounting nexus.properties in a ConfigMap
0fbcb3f 
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
@ricardozanini ricardozanini added this to the v0.6.0 milestone Jun 13, 2021
@ricardozanini
Fixing Operatorr SDK install script
2b10889 
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
@ricardozanini
Fixing curl output
cc42497 
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
@ricardozanini ricardozanini mentioned this pull request Jun 13, 2021
Closed
LCaparelli
LCaparelli reviewed Jun 14, 2021
View reviewed changes
Copy link
Member

@LCaparelli LCaparelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I have some concerns regarding the SDK bump, let me know your thoughts

.github/workflows/nexus-operator-integration-checks.yaml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
hack/ci/install-operator-sdk.sh Show resolved Hide resolved
@ricardozanini
Incorporating java properties to Nexus CR
c306ed9 
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
@ricardozanini
Lint fix and addheaders downgrade
b083f49 
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
@ricardozanini
Copy link
Member Author

@LCaparelli can you try in your end?
https://gist.github.com/ricardozanini/b59ebc4b5267ddcb91abcdf5e9d270d7

I've updated the CR, now we have Spec.Properties to define the server configuration.

@ricardozanini
Explicit set Red Hat image to Dockerbuild and fix permission issues
b72af85 
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
LCaparelli
LCaparelli approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@LCaparelli LCaparelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on my end! Also logged in to the container and ran cat /nexus-data/etc/nexus.properties, we can read just fine :-)

Thanks again!

@LCaparelli LCaparelli merged commit f8f095f into main Aug 17, 2021
@LCaparelli LCaparelli deleted the issue-204 branch August 17, 2021 01:04
@ricardozanini ricardozanini mentioned this pull request Jan 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LCaparelli LCaparelli LCaparelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

Feature request: allow setting settings in nexus.properties (feature flags, etc)
2 participants
@ricardozanini @LCaparelli