Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move admission logic to scaffolded webhook #195

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Move admission logic to scaffolded webhook #195

wants to merge 10 commits into from

Conversation

LCaparelli
Copy link
Member

@LCaparelli LCaparelli commented Dec 16, 2020 •
edited
Loading

TODO:

  • Scaffold the webhook logic
  • Move admission logic to webhook
  • Hash out the import cycles with (hopefully) clever re-arranging of packages
  • Fix the tests
  • We must make sure only valid Nexus CRs are used in the integration suite. Document this in contributor's guide.
  • Write auto-generation for a separate installation manifest for users who want to try this out without needing to install cert-manager
  • Add cert-manager as a dependency in CSV
  • Document
    • The dependency on cert-manager, some succinct reasoning as to why we use it and how to install it
    • How to install without cert-manager to make trying out the operator easier (important to point out the user MUST always provide valid Nexus instances for this to work properly)
  • Update changelog
  • Test installing via OLM

Fix #174

Signed-off-by: Lucas Caparelli lucas.caparelli112@gmail.com

@LCaparelli LCaparelli self-assigned this Dec 16, 2020
@LCaparelli LCaparelli added enhancement 👑 New feature or request WIP 👷‍♀️ Work In Progress PR labels Dec 17, 2020
@LCaparelli LCaparelli added this to the v0.6.0 milestone Dec 17, 2020
@LCaparelli
Move admission logic to scaffolded webhook
8efd553 
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
@LCaparelli
Break FakeClient into FakeClient and FakeDisc
2884258 
Improves cohesion for the FakeClient/FakeDisc and breaks an import cycle
created due to admission testing needing a fake discovery implementation
and the previous implementation also importing v1alpha1.

Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
@LCaparelli
Fix tests
952b87b
@LCaparelli
Enable kustomization for webhooks and cert-manager
63e2970
@LCaparelli
Fix webhook group
9a86fc7
@LCaparelli
Inform reader no changes or validation takes place in e2e tests
accc48c 
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
@LCaparelli
Create auto-generation for webhookless installer manifest
28bd7f3 
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
@LCaparelli
Fallback to in-reconcile admission if webhooks are not in use
cb1732a 
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
@LCaparelli LCaparelli force-pushed the issue-174 branch 5 times, most recently from 244be89 to 4a02897 Compare February 4, 2021 00:02
@LCaparelli
Make webhookless installer generator work on CI
428388b 
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
@LCaparelli
Add and document dependency on cert-manager
acd762c 
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
@LCaparelli LCaparelli modified the milestones: v0.6.0, v0.7.0 Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LCaparelli LCaparelli

Labels
enhancement 👑 New feature or request WIP 👷‍♀️ Work In Progress PR
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

Use Admission Webhooks to set default values and validate to Nexus CR
1 participant
@LCaparelli