-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcd_docker 7: move etcd dependency down to 3.5.4 #4151
Merged
andrewmains12
merged 1 commit into
uber/20220830-grpc_update
from
pr/andrewmains12/amains/grpc-update/etcd_tests.review/720abd40
Sep 2, 2022
Merged
etcd_docker 7: move etcd dependency down to 3.5.4 #4151
andrewmains12
merged 1 commit into
uber/20220830-grpc_update
from
pr/andrewmains12/amains/grpc-update/etcd_tests.review/720abd40
Sep 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/720abd40
branch
from
September 2, 2022 17:06
590a1ca
to
1d5682b
Compare
justinjc
approved these changes
Sep 2, 2022
andrewmains12
deleted the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/720abd40
branch
September 2, 2022 17:47
andrewmains12
added a commit
that referenced
this pull request
Sep 9, 2022
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
andrewmains12
added a commit
that referenced
this pull request
Sep 9, 2022
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
andrewmains12
added a commit
that referenced
this pull request
Sep 26, 2022
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
andrewmains12
added a commit
that referenced
this pull request
Sep 26, 2022
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
andrewmains12
added a commit
that referenced
this pull request
Oct 14, 2022
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
saad-zaman
pushed a commit
that referenced
this pull request
Feb 28, 2023
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
saad-zaman
pushed a commit
that referenced
this pull request
Mar 2, 2023
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
andrewmains12
added a commit
that referenced
this pull request
Mar 14, 2023
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
andrewmains12
added a commit
that referenced
this pull request
Mar 14, 2023
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
andrewmains12
added a commit
that referenced
this pull request
Mar 24, 2023
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
andrewmains12
added a commit
that referenced
this pull request
Mar 28, 2023
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
justinjc
pushed a commit
that referenced
this pull request
Mar 29, 2023
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
andrewmains12
added a commit
that referenced
this pull request
Mar 30, 2023
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
saad-zaman
pushed a commit
that referenced
this pull request
Apr 4, 2023
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
justinjc
pushed a commit
that referenced
this pull request
Apr 10, 2023
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
saad-zaman
pushed a commit
that referenced
this pull request
Apr 19, 2023
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
shivam-kumar-uber
pushed a commit
that referenced
this pull request
Apr 26, 2023
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
fengcheng1518
pushed a commit
that referenced
this pull request
Oct 9, 2023
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
fengcheng1518
pushed a commit
that referenced
this pull request
Oct 10, 2023
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
fengcheng1518
pushed a commit
that referenced
this pull request
Oct 11, 2023
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
shaan420
pushed a commit
that referenced
this pull request
Nov 13, 2023
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
tarunisrani
pushed a commit
that referenced
this pull request
Jul 12, 2024
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
tarunisrani
pushed a commit
that referenced
this pull request
Jul 12, 2024
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
shaan420
pushed a commit
that referenced
this pull request
Aug 5, 2024
This changes our etcd version *down* to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd 3.6.0. As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the `embed` and `integration` packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable, I'm taking the opportunity to do so. commit-id:720abd40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes our etcd version down to 3.5.4 from 3.6.0-alpha.0. In #4087, we made the choice to go to
an alpha version of etcd in order to get around the thorny dependency issues described in that ticket. This was partially on the assumption that
etcd would release a full 3.6.0 version in the months following. As of 9/2/2022, that hasn't happened--no progress seems to have been made on etcd
3.6.0.
As described in #4144, we've since addressed the dependency issues via other means, removing our dependency on the
embed
andintegration
packages. This allows us to move back to an etcd stable version, 3.5.4. Since stable versions are generally preferable,I'm taking the opportunity to do so.
commit-id:720abd40