Fixed inactive tab text with Qt6 #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a change (or bug?) in Qt6, using a stylesheet for setting the font of active/inactive tabs doesn't work as it did with Qt5. Here, `QStyle` is used directly, which is always the best approach because stylesheets can interfere with the widget style in bad ways. Fixes #1112
|
@yan12125 |
|
Works as described with 6.6.2. |
|
Thanks! Although I don't fully understand QStyle, I trust your expertise. |
|
@yan12125, |
|
I have some local changes for minor fixes and improvements, which should be finished in one or two days. Besides that, I'm waiting for #1110 and lxqt/qtermwidget#540. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a change (or bug?) in Qt6, using a stylesheet for setting the font of active/inactive tabs doesn't work as it did with Qt5.
Here,
QStyleis used directly, which is always the best approach because stylesheets can interfere with the widget style in bad ways.Fixes #1112