Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single instance dropdown #1114

Closed
wants to merge 1 commit into from
Closed

Single instance dropdown #1114

wants to merge 1 commit into from

Conversation

marcusbritanicus
Copy link

@marcusbritanicus marcusbritanicus commented Apr 25, 2024

This PR adds preliminary support for single instance mode for drop-down mode. Additionally, it adds support for toggling the drop-down instance via qterminal -d command line. On wayland, we can simply add a command-binding pair for most compositors. On wayfire, this would simply be adding the following lines under the [command] section.

binding_qterminal_dd: KEY_F12
command_qterminal_dd: qterminal -d

If an instance of qterminal in the drop-down mode exists, it will toggle it. Otherwise, a new drop-down instance will be created.

Cc: @yan12125 @stefonarch @tsujan

Edit:
This fixes both #1028 and #1059.

@stefonarch
Copy link
Member

Very nice! But we should follow our rules: One issue - one commit/PR otherwise it's hard to keep track. For me single instance + -d option could go together though.

@marcusbritanicus
Copy link
Author

I'll close this PR and open a new one. I'm finding it a pain to rebase it on master.

@marcusbritanicus marcusbritanicus deleted the single-instance-dropdown branch April 25, 2024 17:01
@marcusbritanicus marcusbritanicus restored the single-instance-dropdown branch April 25, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants